git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Python3 and Pig Hook


Hi,

I have a small update for the Pig Hook to make it compatible with Python3, and it seems complicated to set up a test for, b/c I would have to configure Pig in a testing suite. I noticed there weren't any tests for it listed before. Would it be okay for me to skip the test in this case? Could I have some guidance?

My change is just to explicitly cast strings to byte arrays:
https://github.com/overstock/incubator-airflow/commit/8bb729c358ae13a9f7f5408b0a26e19b29a132ec

There is additional information available here:
https://stackoverflow.com/questions/50652034/pig-hook-in-airflow-doesnt-work-for-python3

Thank you,
Murium



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-airflow-development/msg03562.html on line 81
Call Stack
#TimeMemoryFunctionLocation
10.0008363112{main}( ).../msg03562.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-airflow-development/msg03562.html on line 81
Call Stack
#TimeMemoryFunctionLocation
10.0008363112{main}( ).../msg03562.html:0