git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2464: ARTEMIS-1859 Incorrect routing with AMQ...


Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2464#discussion_r243026861
  
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java ---
    @@ -216,9 +219,23 @@ public RemotingConnection getRemotingConnection() {
           flow();
        }
     
    -   public RoutingType getRoutingType(Receiver receiver, SimpleString address) {
    +   public RoutingType getRoutingType(Receiver receiver, SimpleString address, AMQPMessage message) {
           org.apache.qpid.proton.amqp.messaging.Target target = (org.apache.qpid.proton.amqp.messaging.Target) receiver.getRemoteTarget();
    -      return target != null ? getRoutingType(target.getCapabilities(), address) : getRoutingType((Symbol[]) null, address);
    +      // the target may be null or have no capabilities in the case of an anonymous producer
    +      if (target != null && target.getCapabilities() != null) {
    --- End diff --
    
    I'll rework this. Thanks for the feedback, @gemmellr.


---