git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2414: ARTEMIS-1710 Allow management msgs to e...


Github user wy96f commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2414#discussion_r230676923
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java ---
    @@ -1244,6 +1244,9 @@ private static PageSubscription locateSubscription(final long queueID,
              if (queueInfo != null) {
                 SimpleString address = queueInfo.getAddress();
                 PagingStore store = pagingManager.getPageStore(address);
    --- End diff --
    
    private Map<SimpleString, Collection<Integer>> getPageInformationForSync(PagingManager pagingManager) throws Exception {
          Map<SimpleString, Collection<Integer>> info = new HashMap<>();
          for (SimpleString storeName : pagingManager.getStoreNames()) {
             PagingStore store = pagingManager.getPageStore(storeName);
             info.put(storeName, store.getCurrentIds());
             store.forceAnotherPage();
          }
          return info;
       }
    
    In getPageInformationForSync(), do we need to judge null PagingStore?


---