git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2401: ARTEMIS-1710 Allow management msgs to p...


Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2401#discussion_r229088266
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java ---
    @@ -700,7 +720,7 @@ public boolean checkMemory(final Runnable runWhenAvailable) {
     
        @Override
        public void addSize(final int size) {
    -      boolean globalFull = pagingManager.addSize(size).isGlobalFull();
    +      boolean globalFull = !ignoreGlobalMaxSize && pagingManager.addSize(size).isGlobalFull();
    --- End diff --
    
    This would affect the reported size though, which for someone operating the broker is important it returns a correct and valid value.


---