git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis issue #2396: ARTEMIS-2149 Protecting message.sendBuffer fro...


Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2396
  
    about previously from 2.0.0 I can only think that we have made improvements that probably allowed more load. I ran the same test against 2.0.0 and it fails as well.
    
    Prior to 2.0.0 we would always copy the buffer during send and duplicate it. I tried to create a single buffer upon receiving and call saveToBuffer using the read-only-buffer.
    
    During the process I missed this race. Even though I tested it quite a lot.
    
    Regarding validBuffer, The application is single threaded upon receiving a message. We only need to validate it later during encode, which I added the synchronize. So i think it's ok?


---