git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2363: NO-JIRA close connection factory in CLI


GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2363

    NO-JIRA close connection factory in CLI

    Fix warning seen in logs during test case runs, caused by CF not being closed.
    
    Oct 10, 2018 8:53:18 PM org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl finalize
    WARN: AMQ212008: I am closing a core ClientSessionFactory you left open. Please make sure you close all ClientSessionFactories explicitly before letting them go out of scope! 639,542,871
    java.lang.Exception
    	at org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.<init>(ClientSessionFactoryImpl.java:171)
    	at org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:779)
    	at org.apache.activemq.artemis.cli.commands.messages.DestAbstract.getManagementSession(DestAbstract.java:103)
    	at org.apache.activemq.artemis.cli.commands.messages.DestAbstract.getQueueAttribute(DestAbstract.java:127)
    	at org.apache.activemq.artemis.cli.commands.messages.DestAbstract.getQueueIdFromName(DestAbstract.java:116)
    	at org.apache.activemq.artemis.cli.commands.messages.Producer.execute(Producer.java:75)
    	at org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:150)
    	at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:98)
    	at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:125)
    	at org.apache.activemq.artemis.cli.Artemis.main(Artemis.java:81)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis CloseCFInCLI

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2363
    
----
commit 14c77783940d25669abfc96201a59ca2f4fe5efa
Author: Michael André Pearce <michael.andre.pearce@...>
Date:   2018-10-10T21:11:21Z

    NO-JIRA close connection factory in CLI
    
    Fix warning seen in logs during test case runs, caused by CF not being closed.
    
    Oct 10, 2018 8:53:18 PM org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl finalize
    WARN: AMQ212008: I am closing a core ClientSessionFactory you left open. Please make sure you close all ClientSessionFactories explicitly before letting them go out of scope! 639,542,871
    java.lang.Exception
    	at org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.<init>(ClientSessionFactoryImpl.java:171)
    	at org.apache.activemq.artemis.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:779)
    	at org.apache.activemq.artemis.cli.commands.messages.DestAbstract.getManagementSession(DestAbstract.java:103)
    	at org.apache.activemq.artemis.cli.commands.messages.DestAbstract.getQueueAttribute(DestAbstract.java:127)
    	at org.apache.activemq.artemis.cli.commands.messages.DestAbstract.getQueueIdFromName(DestAbstract.java:116)
    	at org.apache.activemq.artemis.cli.commands.messages.Producer.execute(Producer.java:75)
    	at org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:150)
    	at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:98)
    	at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:125)
    	at org.apache.activemq.artemis.cli.Artemis.main(Artemis.java:81)

----


---