git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2312: ARTEMIS-2085 - Improve validation of MD...


Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2312#discussion_r224148916
  
    --- Diff: artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java ---
    @@ -603,7 +596,11 @@ public void setMaxSession(final Integer value) {
              logger.trace("setMaxSession(" + value + ")");
           }
     
    -      maxSession = value;
    +      if ( value < 1 ) {
    +         logger.warn("Invalid number of session (negative):" + value + ", defaulting to 1.");
    --- End diff --
    
    this requires a declared  logger in ActiveMQRALogger and logger code


---