git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-nms-openwire pull request #4: Fix exception when creating session v...


GitHub user v-kabanov opened a pull request:

    https://github.com/apache/activemq-nms-openwire/pull/4

    Fix exception when creating session via NetTxConnectionFactory - parsâ?¦

    â?¦ing Guid string in NetTxConnection
    
    Without the change I have to use workaround:
    ```
               var factory = new NetTxConnectionFactory(ConnectUri);
    
                using (var connection = factory.CreateNetTxConnection("admin", "***"))
                {
                    connection.Start();
                    // work around - 2 lines below; without it connection.CreateSession() throws exception
                    Guid brokerGuid = Guid.Parse(((Connection)connection).ResourceManagerId);
                    ((NetTxConnection) connection).ConfiguredResourceManagerId = brokerGuid;
    
                    using (var session = connection.CreateSession(AcknowledgementMode.Transactional))
                }
    
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/v-kabanov/activemq-nms-openwire master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-nms-openwire/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit d55095212249e7f7d5fc3f059f8eeb05f86034c4
Author: Vasily Kabanov <vasily.kabanov@...>
Date:   2018-10-09T23:46:38Z

    Fix exception when creating session via NetTxConnectionFactory - parsing Guid string in NetTxConnection

----


---