git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2338: ARTEMIS-2101 Do not cluster OpenWire ad...


Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2338#discussion_r221534313
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java ---
    @@ -350,6 +352,8 @@ private String appendIgnoresToFilter(String filterString) {
           filterString += "!" + storeAndForwardPrefix;
           filterString += ",!" + managementAddress;
           filterString += ",!" + managementNotificationAddress;
    +      //advisory topics shouldn't be clustered
    +      filterString += ",!" + ADVISORY_TOPIC_PREFIX;
    --- End diff --
    
    This is Openwire specific, should avoid pushing protocol specifics into core.
    
    What happens it another protocol needs an address not clustered?
    
    Would be better to design this in an agnostic way, eg a flag on the address or queue, to not cluster bridge, which the protocol managers can set on creating


---