git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq pull request #298: AMQ-7052 - Fix JdbcXARecoveryBrokerTest and mLev...


GitHub user alanprot opened a pull request:

    https://github.com/apache/activemq/pull/298

    AMQ-7052 - Fix JdbcXARecoveryBrokerTest and mLevelDBXARecoveryBrokerTest tests

    Fix the following tests:
    
    JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>
    
    JdbcXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391 null
    
    mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>
    
    mKahaDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeCommitOnRestart:391 null
    
    mLevelDBXARecoveryBrokerTest>CombinationTestSupport.runBare:107->XARecoveryBrokerTest.testPreparedTransactionRecoveredPurgeRollbackOnRestart:332 expected:<0> but was:<4>
    
    Those tests are failing because this feature (purge transactions after reboot) was only implemented on the KahaDBPersistenceAdapter.
    
    Change that introduced this feature: https://github.com/apache/activemq/commit/ce7498c971b99e2515f07aab36418a1a0f19c03e
    
    The tests are failing because the class XARecoveryBrokerTest is used to test multiples adapters that are not implementing the same feature.
    
    Steps to reproduce:
    
    > git checkout https://github.com/apache/activemq/tree/activemq-5.15.x
    > cd activemq-unit-tests
    > mvn clean install -Dtest=JdbcXARecoveryBrokerTest

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alanprot/activemq activemq-5.15.x-Xa-rollback-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #298
    
----
commit 21bb145534bf929e0a1ee820bec9e156129b6e96
Author: Alan Protasio <alanprot@...>
Date:   2018-09-14T08:39:17Z

    AMQ-7052 - Fix JdbcXARecoveryBrokerTest and mLevelDBXARecoveryBrokerTest tests

----


---