git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...


Github user RaiSaurabh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2089#discussion_r188589506
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java ---
    @@ -90,6 +92,7 @@ public SharedNothingBackupQuorum(StorageManager storageManager,
           this.networkHealthCheck = networkHealthCheck;
           this.voteRetries = voteRetries;
           this.voteRetryWait = voteRetryWait;
    +      this.quorumVoteWait = quorumVoteWait;
    --- End diff --
    
    The parameter is already validated when it is picked form the broker .xml.  You can check class "FileConfigurationParser" L1322 and L1352 for validation of number greater than zero.


---



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-activemq-developers/msg08469.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0009363704{main}( ).../msg08469.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-activemq-developers/msg08469.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0009363704{main}( ).../msg08469.html:0