git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...


Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2090#discussion_r188532813
  
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java ---
    @@ -95,6 +97,8 @@
     
        private final SimpleString clientId;
     
    +   private final Set<Long> rollbackedIds = new ConcurrentHashSet<>();
    --- End diff --
    
    It could belong to `AMQConsumer` instead of here? That will make it less contended, because owned exclusively by the consumer 


---