[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2090: ARTEMIS-1868 Openwire doesn't add deliv...

Github user franz1981 commented on a diff in the pull request:
    --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/ ---
    @@ -308,6 +312,8 @@ public int sendMessage(MessageReference reference,
                               ServerConsumer consumer,
                               int deliveryCount) {
           AMQConsumer theConsumer = (AMQConsumer) consumer.getProtocolData();
    +      //clear up possible rolledback ids.
    +      rollbackedIds.remove(message.getMessageID());
    --- End diff --
    That's in the hot path of any send operation and `rollbackIds` would be contended by all the producers/consumers using the same AMQSession and it create a Long instance on any call of it. There are other ways to implement it?


( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-activemq-developers/msg08466.html on line 86
Call Stack
10.0011363704{main}( ).../msg08466.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-activemq-developers/msg08466.html on line 86
Call Stack
10.0011363704{main}( ).../msg08466.html:0