git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2089: ARTEMIS-1866: Make wait time for reply ...


Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2089#discussion_r187945798
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ReplicaPolicy.java ---
    @@ -57,6 +57,8 @@
     
        private long voteRetryWait;
     
    +   private int quorumVoteWait = ActiveMQDefaultConfiguration.getDefaultQuorumVoteWait();
    --- End diff --
    
    It would be better to just use the one provided by the constructor and declare this `final` if is not meant to be modified anymore


---



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-activemq-developers/msg08452.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0008358472{main}( ).../msg08452.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-activemq-developers/msg08452.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0008358472{main}( ).../msg08452.html:0