git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #1722: (WIP DO NOT MERGE) ARTEMIS-1545 Support...


Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1722#discussion_r157484746
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Packet.java ---
    @@ -42,6 +42,21 @@ default int expectedEncodeSize() {
           return INITIAL_PACKET_SIZE;
        }
     
    +   default boolean isRequiresResponse() {
    --- End diff --
    
    good point, ill move to PacketImpl the default behaviour.


---



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-activemq-developers/msg08201.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0006363192{main}( ).../msg08201.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-activemq-developers/msg08201.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0006363192{main}( ).../msg08201.html:0