[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #1722: (WIP DO NOT MERGE) ARTEMIS-1545 Support...

Github user franz1981 commented on a diff in the pull request:
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/ ---
    @@ -42,6 +42,21 @@ default int expectedEncodeSize() {
           return INITIAL_PACKET_SIZE;
    +   default boolean isRequiresResponse() {
    --- End diff --
    be careful to use `default` method on hottest paths vs common abstract methods on superclass: they lack CHA AFAIK! and