git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #1722: (WIP DO NOT MERGE) ARTEMIS-1545 Support...


Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1722#discussion_r157459675
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/Packet.java ---
    @@ -42,6 +42,21 @@ default int expectedEncodeSize() {
           return INITIAL_PACKET_SIZE;
        }
     
    +   default boolean isRequiresResponse() {
    --- End diff --
    
    be careful to use `default` method on hottest paths vs common abstract methods on superclass: they lack CHA AFAIK!
    http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-April/thread.html#17649 and https://stackoverflow.com/questions/30312096/java-default-methods-is-slower-than-the-same-code-but-in-an-abstract-class


---