git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #1713: fixing compatibility issues + testsuite...


Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1713#discussion_r157330521
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java ---
    @@ -614,7 +614,9 @@ public void createAddress(SimpleString address,
                                  Set<RoutingType> routingTypes,
                                  final boolean autoCreated) throws ActiveMQException {
           CreateAddressMessage request = new CreateAddressMessage(address, routingTypes, autoCreated, true);
    -      sessionChannel.sendBlocking(request, PacketImpl.NULL_RESPONSE);
    +      if (!sessionChannel.getConnection().isVersionBeforeAddressChange()) {
    +         sessionChannel.sendBlocking(request, PacketImpl.NULL_RESPONSE);
    --- End diff --
    
    @mtaylor  this is fixing some compatibilty issues


---