git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...


Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2080#discussion_r187455572
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
    @@ -946,7 +946,7 @@ public boolean isReplicaSync() {
           } else if (activation instanceof SharedNothingBackupActivation) {
              return ((SharedNothingBackupActivation) activation).isRemoteBackupUpToDate();
           } else {
    -         throw ActiveMQMessageBundle.BUNDLE.methodNotApplicable();
    --- End diff --
    
    Makes sense, although ARTEMIS-1018 Duplicate error ids on different error mesages. Thanks for not making it worse, I guess.


---