git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...


Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2080#discussion_r187453307
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
    @@ -946,7 +946,7 @@ public boolean isReplicaSync() {
           } else if (activation instanceof SharedNothingBackupActivation) {
              return ((SharedNothingBackupActivation) activation).isRemoteBackupUpToDate();
           } else {
    -         throw ActiveMQMessageBundle.BUNDLE.methodNotApplicable();
    --- End diff --
    
    @jdanekrh, yes. That is the only place where that message was used but I elected not to delete that method so that developers would know that the message's id (i.e. `119118`) shouldn't be used again since message ids should be unique.


---