git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2081: ARTEMIS-1783 add Guava dep in artemis-c...


Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2081#discussion_r187390384
  
    --- Diff: artemis-core-client/pom.xml ---
    @@ -118,6 +118,10 @@
              <groupId>io.netty</groupId>
              <artifactId>netty-common</artifactId>
           </dependency>
    +      <dependency>
    +         <groupId>com.google.guava</groupId>
    --- End diff --
    
    The artemis-core-client module *is* using Guava directly. If you run `mvn dependency:analyze` without my fix you'll see it complain about the undeclared dependency or you can just look in `org.apache.activemq.artemis.core.message.impl.CoreMessageObjectPools` to see where Guava is used.


---