git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2081: ARTEMIS-1783 add Guava dep in artemis-c...


Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2081#discussion_r187389221
  
    --- Diff: artemis-core-client/pom.xml ---
    @@ -118,6 +118,10 @@
              <groupId>io.netty</groupId>
              <artifactId>netty-common</artifactId>
           </dependency>
    +      <dependency>
    +         <groupId>com.google.guava</groupId>
    --- End diff --
    
    I would prefer not having more collections added directly on core-client.. having it concentrated through commons would avoid that from being added. (wouldn't compile if someone added by mistake)


---