[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2075: ARTEMIS-1852 PageCursorProvider is leak...

Github user franz1981 commented on a diff in the pull request:
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/ ---
    @@ -239,8 +239,28 @@ public void stop() {
           for (PageSubscription cursor : activeCursors.values()) {
    -      executor.shutdownNow();
    +      int pendingCleanupTasks = scheduledCleanup.get();
    --- End diff --
    `PagingStoreImpl` seems the one that is owning the executor
    I will move the `executor.shutdownNow` from the `PageCursorProvider` to `PagingStoreImpl` while leaving at least the flush of the cleanup tasks on it :+1: 
    Good points!


( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-activemq-developers/msg08097.html on line 89
Call Stack
10.0006363704{main}( ).../msg08097.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-activemq-developers/msg08097.html on line 89
Call Stack
10.0006363704{main}( ).../msg08097.html:0