git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2075: ARTEMIS-1852 PageCursorProvider is leak...


Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2075#discussion_r186410023
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java ---
    @@ -239,8 +239,28 @@ public void stop() {
           for (PageSubscription cursor : activeCursors.values()) {
              cursor.stop();
           }
    -
    -      executor.shutdownNow();
    +      int pendingCleanupTasks = scheduledCleanup.get();
    --- End diff --
    
    @clebertsuconic :+1: TBH you're right! So let me check if it already fixes the error and I will move the logic of the pending runnable tasks to be executed on the owner (the `PageStore` I suppose)...wdyt?


---