git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2075: ARTEMIS-1852 PageCursorProvider is leak...


Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2075#discussion_r186406297
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java ---
    @@ -239,8 +239,28 @@ public void stop() {
           for (PageSubscription cursor : activeCursors.values()) {
              cursor.stop();
           }
    -
    -      executor.shutdownNow();
    +      int pendingCleanupTasks = scheduledCleanup.get();
    --- End diff --
    
    Nice catch.. very nice...
    
    However.. I'm not sure why we were calling shutdown here. PageCursor doesn't own the executor...
    
    this is using ArtemisExecutor. where shutdownNow will call an empty method.. and getPendingTasks will return also an empty array.
    
    
    I think the only thing you should do here is call the flush method.


---



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-activemq-developers/msg08094.html on line 94
Call Stack
#TimeMemoryFunctionLocation
10.0007358472{main}( ).../msg08094.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-activemq-developers/msg08094.html on line 94
Call Stack
#TimeMemoryFunctionLocation
10.0007358472{main}( ).../msg08094.html:0