git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] activemq-artemis pull request #2071: ARTEMIS-1804 don't call deprecated SslH...


GitHub user jdanekrh opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2071

    ARTEMIS-1804 don't call deprecated SslHandler#close() to avoid NPE in Netty

    The stacktrace of the exception involves a deprecated method. For some reason, using the recommended alternative does not produce the exception... Could this PR be step in the right direction?
    
    The Netty exception appears when OpenWire client which is using SSL disconnects:
    
    2018-05-04 09:56:44,424 WARN  [io.netty.handler.ssl.SslHandler] [id: 0x1dcd30fa, L:/127.0.0.1:61617 ! R:/127.0.0.1:33006] flush() raised a masked exception.: java.lang.NullPointerException
            at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:760) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:752) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1625) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.access$600(SslHandler.java:165) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler$1.run(SslHandler.java:649) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) [artemis-commons-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/activemq-artemis jd_netty_flush_woodo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2071.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2071
    
----
commit b38a424a34fe0a6d3cef220e13bc906164b99e8c
Author: Jiri Danek <jdanek@...>
Date:   2018-05-04T12:15:43Z

    ARTEMIS-1804 don't call deprecated SslHandler#close() to avoid NPE in Netty
    
    The Netty exception appears when OpenWire client which is using SSL disconnects:
    
    2018-05-04 09:56:44,424 WARN  [io.netty.handler.ssl.SslHandler] [id: 0x1dcd30fa, L:/127.0.0.1:61617 ! R:/127.0.0.1:33006] flush() raised a masked exception.: java.lang.NullPointerException
            at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:760) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:752) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1625) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler.access$600(SslHandler.java:165) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.handler.ssl.SslHandler$1.run(SslHandler.java:649) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) [netty-all-4.1.24.Final.jar:4.1.24.Final]
            at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) [artemis-commons-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]

----


---



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-activemq-developers/msg08076.html on line 129
Call Stack
#TimeMemoryFunctionLocation
10.0008368824{main}( ).../msg08076.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-activemq-developers/msg08076.html on line 129
Call Stack
#TimeMemoryFunctionLocation
10.0008368824{main}( ).../msg08076.html:0